-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stabilise redirected-noqa
(RUF101
)
#12869
Conversation
|
code | total | + violation | - violation | + fix | - fix |
---|---|---|---|---|---|
RUF101 | 3 | 3 | 0 | 0 | 0 |
Linter (preview)
✅ ecosystem check detected no linter changes.
Most of the RUF027 hits seem to be true positives that I think projects would very much like to know about (so this shows the value of stabilising the rule)... however, this one is a false positive, that I think wouldn't be too hard for us to fix: https://github.com/pytest-dev/pytest/blob/38ad84bafd18d15ceff1960d636c693560337844/src/_pytest/main.py#L1055-L1060 |
Okay, this is another false positive: https://github.com/pypa/cibuildwheel/blob/c6dd39bd834ed458bb627c294854832e21971f1a/cibuildwheel/macos.py#L742. The rule should exclude logging calls in the same way that it excludes |
I've taken the RUF027 stabilisation out of this PR. I'll put up a separate PR to reduce the false positives after the release is out. |
Summary
Stabilise
twooneruff
rule for the 0.6 release:missing-f-string-syntax
(RUF027
)redirected-noqa
(RUF101
)These have both been in preview for a while and there are no open issues about either of them. They also both seem like very useful rules.
I'm fixing a tiny oversight in the RUF027 logic as part of this PR, but it's never been reported and it's unlikely to come up.Test Plan
cargo test -p ruff_linter --lib
+ ecosystem