Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the search path tests on MacOS #12503

Merged
merged 1 commit into from
Jul 25, 2024
Merged

Fix the search path tests on MacOS #12503

merged 1 commit into from
Jul 25, 2024

Conversation

MichaReiser
Copy link
Member

Summary

tempfile on MacOS uses some symlink magic which confuses the watcher.

We should resolve symlinks when resolving the search paths. But for now, normalize the paths in the test.

Test Plan

cargo test on MacOs` passes

@github-actions GitHub Actions
Copy link
Contributor

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

@MichaReiser MichaReiser added the red-knot Multi-file analysis & type inference label Jul 25, 2024
@MichaReiser MichaReiser merged commit 2ce3e3a into main Jul 25, 2024
20 checks passed
@MichaReiser MichaReiser deleted the fix-search-path-tests-on-mac branch July 25, 2024 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carljm carljm Awaiting requested review from carljm carljm is a code owner

@AlexWaygood AlexWaygood Awaiting requested review from AlexWaygood AlexWaygood is a code owner

Assignees
No one assigned
Labels
red-knot Multi-file analysis & type inference
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@MichaReiser