[red-knot] Use vendored typeshed stubs for stdlib module resolution #12224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
18 tasks
|
AlexWaygood
added a commit
that referenced
this pull request
Jul 7, 2024
Fixes CI errors seen in #12224 (comment) x-ref python-trio/trio@17b3644
AlexWaygood
added a commit
that referenced
this pull request
Jul 7, 2024
…n` (#12225) Fixes CI errors seen in #12224 (comment) x-ref python-trio/trio@17b3644
MichaReiser
approved these changes
Jul 8, 2024
There was a problem hiding this comment.
Overall looks good.
I would prefer if we can avoid introducing a FilePathRef, see the inline comment why and a solution on how we can avoid it.
Overall, I start to like Carl's recommendation more and more. I think the current design makes some transformation unnecessarily verbose. But I'm okay moving forward with this (but would prefer for Carl to have a look at the PR as well)
MichaReiser
force-pushed
the
files-use-absolute-paths
branch
from
c64a9a5
to
affd89f
Compare
AlexWaygood
force-pushed
the
module-resolver-vendored-paths-2
branch
4 times, most recently
from
6ee4e7c
to
3fb2a25
Compare
evanrittenhouse
pushed a commit
to evanrittenhouse/ruff
that referenced
this pull request
Jul 8, 2024
…n` (astral-sh#12225) Fixes CI errors seen in astral-sh#12224 (comment) x-ref python-trio/trio@17b3644
evanrittenhouse
pushed a commit
to evanrittenhouse/ruff
that referenced
this pull request
Jul 8, 2024
…n` (astral-sh#12225) Fixes CI errors seen in astral-sh#12224 (comment) x-ref python-trio/trio@17b3644
evanrittenhouse
pushed a commit
to evanrittenhouse/ruff
that referenced
this pull request
Jul 8, 2024
…n` (astral-sh#12225) Fixes CI errors seen in astral-sh#12224 (comment) x-ref python-trio/trio@17b3644
carljm
approved these changes
Jul 8, 2024
AlexWaygood
force-pushed
the
module-resolver-vendored-paths-2
branch
from
f17899f
to
d9a40d7
Compare
MichaReiser
force-pushed
the
files-use-absolute-paths
branch
2 times, most recently
from
d9a54da
to
f3818a2
Compare
An error occurred while trying to automatically change base from
files-use-absolute-paths
to
main
July 9, 2024 07:52
AlexWaygood
force-pushed
the
module-resolver-vendored-paths-2
branch
from
4ee6b8f
to
31a22fd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
If the user does not pass a
--custom-typeshed-dirflag via the CLI or via a configuration flag, fall back to using theVendoredFileSystemto resolve standard-library modules in the module resolver. Work towards #11653.(This PR is stacked on top of #12215)
Test Plan
I added a test to
resolver.rsthat demonstrates that vendored files now work