-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove --preview
as a required argument for ruff server
#12053
Conversation
b2254b0
to
62aa56f
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm okay merging this but there are at least two follow-ups that are necessary
- Don't set the
--preview
flag inruff-vscode
if theserver
version is>= 0.5
. We should do this pre-release to avoid that users will unintentionally opt in the future. - I would expect that
ruff server --preview
works the same asruff check --preview
andruff format --preview
and enables all--preview
features (linter and formatter).
I would expect that running ruff server --preview
would enable all preview features similar to setting preview = true
in the settings.
62aa56f
to
5d5392f
Compare
@MichaReiser Thanks for the review! I'll look into addressing the points you brought up.
We also have server settings, |
Summary
ruff server
has reached a point of stabilization, and--preview
is no longer required as a flag.--preview
is still supported as a flag, since future features may be need to gated behind it initially.Test Plan
A simple way to test this is to run
ruff server
from the command line. No error about a missing--preview
argument should be reported.