Use struct fields in TokenValue enum
#11475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhruvmanila
force-pushed
the
dhruv/at-soft-keyword
branch
from
b45040f
to
0fbe59f
Compare
dhruvmanila
force-pushed
the
dhruv/token-value-fields
branch
from
d0072cf
to
c939908
Compare
dhruvmanila
force-pushed
the
dhruv/at-soft-keyword
branch
3 times, most recently
from
35b7a6e
to
09022fa
Compare
dhruvmanila
force-pushed
the
dhruv/token-value-fields
branch
from
c939908
to
796e752
Compare
dhruvmanila
force-pushed
the
dhruv/at-soft-keyword
branch
from
09022fa
to
c64f352
Compare
dhruvmanila
force-pushed
the
dhruv/token-value-fields
branch
from
796e752
to
ae5e7b0
Compare
dhruvmanila
force-pushed
the
dhruv/at-soft-keyword
branch
from
c64f352
to
b154931
Compare
dhruvmanila
force-pushed
the
dhruv/token-value-fields
branch
from
ae5e7b0
to
ff5c204
Compare
dhruvmanila
force-pushed
the
dhruv/at-soft-keyword
branch
from
b154931
to
d391949
Compare
dhruvmanila
force-pushed
the
dhruv/token-value-fields
branch
from
ff5c204
to
96aa59a
Compare
dhruvmanila
force-pushed
the
dhruv/at-soft-keyword
branch
from
d391949
to
cbf7e6d
Compare
dhruvmanila
force-pushed
the
dhruv/token-value-fields
branch
from
96aa59a
to
f77aa09
Compare
dhruvmanila
force-pushed
the
dhruv/at-soft-keyword
branch
from
cbf7e6d
to
f8ffc5c
Compare
dhruvmanila
force-pushed
the
dhruv/token-value-fields
branch
from
f77aa09
to
40f65a4
Compare
MichaReiser
approved these changes
May 27, 2024
dhruvmanila
force-pushed
the
dhruv/token-value-fields
branch
from
40f65a4
to
820d872
Compare
dhruvmanila
added a commit
that referenced
this pull request
May 28, 2024
## Summary This PR updates certain `TokenValue` enum variants to use struct fields instead of tuple variants. The main reason is to avoid a large diff for test snapshots, so it becomes easier to diagnose any issues. This is temporary and will be updated once everything is finalized.
dhruvmanila
added a commit
that referenced
this pull request
May 30, 2024
## Summary This PR updates certain `TokenValue` enum variants to use struct fields instead of tuple variants. The main reason is to avoid a large diff for test snapshots, so it becomes easier to diagnose any issues. This is temporary and will be updated once everything is finalized.
dhruvmanila
added a commit
that referenced
this pull request
May 31, 2024
## Summary This PR is a follow-up to #11475 to use enum values where there's struct with a single field. The main motivation to use struct was to keep the snapshot update to a minimum which allows me to validate it. Now that the validation is done, we can revert it back. ## Test Plan Update the snapshots.
dhruvmanila
added a commit
that referenced
this pull request
May 31, 2024
## Summary This PR updates certain `TokenValue` enum variants to use struct fields instead of tuple variants. The main reason is to avoid a large diff for test snapshots, so it becomes easier to diagnose any issues. This is temporary and will be updated once everything is finalized.
dhruvmanila
added a commit
that referenced
this pull request
May 31, 2024
## Summary This PR is a follow-up to #11475 to use enum values where there's struct with a single field. The main motivation to use struct was to keep the snapshot update to a minimum which allows me to validate it. Now that the validation is done, we can revert it back. ## Test Plan Update the snapshots.
dhruvmanila
added a commit
that referenced
this pull request
Jun 3, 2024
## Summary This PR updates certain `TokenValue` enum variants to use struct fields instead of tuple variants. The main reason is to avoid a large diff for test snapshots, so it becomes easier to diagnose any issues. This is temporary and will be updated once everything is finalized.
dhruvmanila
added a commit
that referenced
this pull request
Jun 3, 2024
## Summary This PR is a follow-up to #11475 to use enum values where there's struct with a single field. The main motivation to use struct was to keep the snapshot update to a minimum which allows me to validate it. Now that the validation is done, we can revert it back. ## Test Plan Update the snapshots.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates certain
TokenValueenum variants to use struct fields instead of tuple variants. The main reason is to avoid a large diff for test snapshots, so it becomes easier to diagnose any issues. This is temporary and will be updated once everything is finalized.