Add automation for updating our vendored typeshed stubs #11427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
dhruvmanila
reviewed
May 14, 2024
|
I manually triggered the workflow to check that everything was working. Looks like it is! #11428 |
18 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a workflow that will create an automated PR every two weeks to update our vendored typeshed stubs. Two notes:
In order for a GitHub Action to be able to create automated PRs, we will need to tick this checkbox in our repo settings:
CI will not be triggered on these automated PRs unless the PR is closed and reopened by a maintainer. I think there are workarounds for this limitation, but we haven't succeeded in figuring out how to do them properly at typeshed or mypy, where we also have workflows to trigger automated PRs.
Test Plan
A GitHub workflow cannot be tested unless it is run, and a workflow cannot be run unless it is already merged to the
mainbranch of a repository. So, that's what I did -- with my Ruff fork! I temporarily merged this PR to themainbranch of my Ruff fork, and ran the workflow. You can see a demo PR here that was automatically created by running this workflow from my fork: AlexWaygood#9