-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ruff server
: Support noqa
comment code action
#11276
Conversation
|
cfb4f18
to
cc45f8c
Compare
Is this PR up-to date with the base PR ( Considering the above code snippet, in the following screen recording (left is new server, right is Screen.Recording.2024-05-07.at.14.14.29.mov |
@dhruvmanila Thanks for pointing this out, I'll investigate. |
b7cd925
to
06ddf50
Compare
cc45f8c
to
eebad65
Compare
@AlexWaygood @dhruvmanila You can ignore the review request, that seemed to happen automatically when I rebased the branch. |
06ddf50
to
d48d094
Compare
@dhruvmanila I've confirmed that b321a3f fixes the issue with multiline diagnostics 👍 |
b321a3f
to
d3e4234
Compare
@T-256 Thanks for this suggestion - can you open an issue for this? |
Summary
Fixes #10594.
Code actions to disable a diagnostic via
noqa
comment are now available.noqa.mp4
DiagnosticFix
has been changed so thatnoqa
code actions appear even for diagnostics with no available quick fix. It can contain quick fix edits,noqa
comment edits, or both.Test Plan
The scenarios that need to be tested are as follows:
noqa
comment.noqa
comment manually should make a diagnostic disappearFix all auto-fixable problems
should not addnoqa
commentsnoqa
comment should make the diagnostic re-appear