-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[refurb
] Implement repeated-global
(FURB154
)
#11187
Conversation
43653f6
to
884e7c9
Compare
|
code | total | + violation | - violation | + fix | - fix |
---|---|---|---|---|---|
FURB154 | 15 | 15 | 0 | 0 | 0 |
Since globals and nonlocals are rare, could we try instead running this rule on every In other words... instead of iterating over every body / statement, can we instead run this for each |
884e7c9
to
333b7f4
Compare
@charliermarsh done. |
Thanks @alex-700. Blocked on me, will review shortly. |
refurb
] implement repeated_global (FURB154) lintrefurb
] Implement repeated-global
(FURB154
)
aec5dc0
to
fde1079
Compare
CodSpeed Performance ReportMerging #11187 will degrade performances by 9.38%Comparing Summary
Benchmarks breakdown
|
I'm confused by the CodSpeed results but my guess is it's just confused by the branch being dated? We didn't touch the parser or lexer here of course. |
Summary
Implement repeated_global (FURB154) lint.
See:
Test Plan
cargo test