Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[flake8-simplify] Avoid raising SIM911 for non-zip attribute calls #11126

Merged
merged 1 commit into from
Apr 24, 2024
Merged

[flake8-simplify] Avoid raising SIM911 for non-zip attribute calls #11126

merged 1 commit into from
Apr 24, 2024

Conversation

charliermarsh
Copy link
Member

Summary

The matches! macro here is slightly off and allows all attribute calls through.

Closes #11125.

@charliermarsh charliermarsh enabled auto-merge (squash) April 24, 2024 13:00
@charliermarsh charliermarsh merged commit 51dec8d into main Apr 24, 2024
18 checks passed
@charliermarsh charliermarsh deleted the charlie/attr branch April 24, 2024 13:05
@github-actions GitHub Actions
Copy link
Contributor

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

@BrewTestBot BrewTestBot mentioned this pull request Apr 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexWaygood AlexWaygood AlexWaygood approved these changes

@zanieb zanieb zanieb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SIM911 false positive (with bad autofix) on non-zip attribute calls
3 participants
@charliermarsh @zanieb @AlexWaygood