Fix syntax for some if-conditions in ci.yaml
#11109
Conversation
| if: github.event_name == 'pull_request' && ${{ | ||
| needs.determine_changes.outputs.code == 'true' | ||
| }} |
There was a problem hiding this comment.
The syntax is incorrect here; this currently seems to always evaluate to true when I sync the main branch of my fork with the upstream main
| @@ -554,7 +552,7 @@ jobs: | |||
| benchmarks: | |||
| runs-on: ubuntu-latest | |||
| needs: determine_changes | |||
| if: ${{ needs.determine_changes.outputs.code == 'true' || github.ref == 'refs/heads/main' }} | |||
| if: ${{ github.repository == 'astral-sh/ruff' && (needs.determine_changes.outputs.code == 'true' || github.ref == 'refs/heads/main') }} | |||
There was a problem hiding this comment.
This should be skipped for forks because our codspeed token is only valid for astral-sh/ruff.
This is quite a long line. I think there are ways of doing multiline if-conditions in GitHub Actions, but they seem to be pretty poorly documented, and I've got it wrong frequently in the past. I'd prefer to just do a very long single-line if-condition, as I currently have.
|
Summary
These CI jobs always fail on my fork whenever I sync my fork with the upstream repo. I have the power to create branches on the upstream
ruffrepo these days but I still occasionally sync and push branches to my fork out of habit, so this is kinda annoying 😛