-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ruff server
: Implement quick fix code actions to ignore a diagnostic with # noqa:
#11085
Conversation
|
2b457ea
to
e1ec26b
Compare
CodSpeed Performance ReportMerging #11085 will not alter performanceComparing Summary
|
45dfb14
to
26d4e86
Compare
…diagnostic generation
7c707d1
to
f5e2634
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be useful to have two separate PRs or commits (whichever you prefer) - one which updates the add_noqa
API on the linter side and the other which uses it in the server for the code action. This would be helpful in understanding the motivation behind the change and also allow us to look at them in isolation. I could even check if I can plug the new API for Jupyter Notebook :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you mind expanding your PR summary with some more detail about what the change is about and add a test plan for both ruff CLI and the vs code extenion.
Good idea, I'll split this PR into two separate PRs. |
Summary
Fixes #10594.
Note: this PR is in draft because the actual code to generate
noqa
comment edits has yet to be implemented. So far, the existing code just sets things up to accept thesenoqa
comment edits.Test Plan
Will be created after this PR gets taken out of draft.