Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

please allow boolean positional arguments (FBT001, FBT002) in case of @override #8867

Closed
ZeeD opened this issue Nov 28, 2023 · 3 comments · Fixed by #8882
Closed

please allow boolean positional arguments (FBT001, FBT002) in case of @override #8867

ZeeD opened this issue Nov 28, 2023 · 3 comments · Fixed by #8882
Assignees
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@ZeeD
Copy link

ZeeD commented Nov 28, 2023

While generally useful, the rules FBT001 and FBT002 may trigger errors if applied to an ovverriden method.

In my case I'm extending a class from a 3rd part library, and I need to override some methods with "naked booleans".

I got the FBT00? errors by ruff in my code, but if I fix them, the original class doesn't work anymore because there are calls to the methods passing the booleans positionally, and they are out of my control.

@Avasam
Copy link
Contributor

Avasam commented Nov 28, 2023

Same reasoning as #3910 and #6958

@zanieb zanieb added bug Something isn't working good first issue Good for newcomers labels Nov 28, 2023
@charliermarsh
Copy link
Member

Makes sense.

@ZeeD
Copy link
Author

ZeeD commented Nov 29, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants