Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some links cannot be read because of the color contrast in dark mode #8519

Closed
etiennebacher opened this issue Nov 6, 2023 · 1 comment · Fixed by #8548
Closed

Some links cannot be read because of the color contrast in dark mode #8519

etiennebacher opened this issue Nov 6, 2023 · 1 comment · Fixed by #8548
Labels
bug Something isn't working documentation Improvements or additions to documentation

Comments

@etiennebacher
Copy link

In the Vim & Neovim section, some links are unreadable because of their color in dark mode:

image

Note that everything's fine in light mode:

image
@charliermarsh
Copy link
Member

Thank you!

@charliermarsh charliermarsh added bug Something isn't working documentation Improvements or additions to documentation labels Nov 7, 2023
@charliermarsh charliermarsh mentioned this issue Nov 7, 2023
Merged
charliermarsh added a commit that referenced this issue Nov 7, 2023
@charliermarsh
Improve detail link contrast in dark mode (#8548)
621e98f 
Use our light-mode styling for links in that context.

<img width="627" alt="Screen Shot 2023-11-07 at 4 34 48 PM"
src="https://github.com/astral-sh/ruff/assets/1309177/1e30c3ac-18e2-4663-876c-75c6f8b67d53">

Closes #8519.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve detail link contrast in dark mode astral-sh/ruff
2 participants
@charliermarsh @etiennebacher