Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add import tkinter as tk to list of default import conventions #5620

Closed
benjamin-kirkbride opened this issue Jul 8, 2023 · 0 comments · Fixed by #5626
Closed

Add import tkinter as tk to list of default import conventions #5620

benjamin-kirkbride opened this issue Jul 8, 2023 · 0 comments · Fixed by #5626
Labels
good first issue Good for newcomers help wanted Contributions especially welcome

Comments

@benjamin-kirkbride
Copy link

The python docs do this in all of the examples, so seems appropriate to include it: https://docs.python.org/3/library/tkinter.html
@charliermarsh charliermarsh added good first issue Good for newcomers help wanted Contributions especially welcome labels Jul 8, 2023
@tjkuson tjkuson mentioned this issue Jul 9, 2023
Merged
dhruvmanila pushed a commit that referenced this issue Jul 9, 2023
@tjkuson
Add tkinter import convention (#5626)
ac2e374 
## Summary

Adds `import tkinter as tk` to the list of default import conventions.

Closes #5620.

## Test Plan

Added `tkinter` to test fixture.

`cargo test`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Contributions especially welcome
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add tkinter import convention tjkuson/ruff
2 participants
@charliermarsh @benjamin-kirkbride