Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand Ruff's default exclusions #5510

Closed
charliermarsh opened this issue Jul 4, 2023 · 4 comments · Fixed by #5513
Closed

Expand Ruff's default exclusions #5510

charliermarsh opened this issue Jul 4, 2023 · 4 comments · Fixed by #5513
Labels
configuration Related to settings and configuration

Comments

@charliermarsh
Copy link
Member

Like Black, I'd like to add:

  • .vscode
  • .ipynb_checkpoints
  • .pytest_cache

Unlike Black, I'd also like to add .pyenv.

@charliermarsh charliermarsh added the configuration Related to settings and configuration label Jul 4, 2023
@charliermarsh
Copy link
Member Author

Anyone for or against this?

@dhruvmanila
Copy link
Member

What's the motivation behind .pyenv? Isn't that probably always going to be in the home directory unlike others which could be in a project directory?

@charliermarsh
Copy link
Member Author

It's relevant in the context of VS Code: #5509

@dhruvmanila
Copy link
Member

Makes sense then! No objections from my side 👍

charliermarsh added a commit that referenced this issue Jul 4, 2023
… excludes (#5513)

## Summary

VS Code extensions are
[recommended](https://code.visualstudio.com/docs/python/settings-reference#_linting-settings)
to exclude `.vscode` and `site-packages`. Black also now omits
`.vscode`, `.pytest_cache`, and `.ipynb_checkpoints` by default.
Omitting `.pyenv` is similar to omitting virtual environments, but
really only matters in the context of VS Code (see:
#5509).

Closes: #5510.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
configuration Related to settings and configuration
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants