Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[red-knot] Narrowing on s == "foo" where s is of type LiteralString #14648

Closed
InSyncWithFoo opened this issue Nov 28, 2024 · 0 comments · Fixed by #14649
Closed

[red-knot] Narrowing on s == "foo" where s is of type LiteralString #14648

InSyncWithFoo opened this issue Nov 28, 2024 · 0 comments · Fixed by #14649
Labels
red-knot Multi-file analysis & type inference

Comments

@InSyncWithFoo
Copy link
Contributor

InSyncWithFoo commented Nov 28, 2024 •
edited
Loading

For any symbol s of type LiteralString, it should be safe to narrow it according to comparisons of the pattern s == "...".

a: LiteralString

if a == "foo":
	reveal_type(a)  # revealed: Literal["foo"]

This issue is part of #13694.
@InSyncWithFoo InSyncWithFoo mentioned this issue Nov 28, 2024
Merged
@AlexWaygood AlexWaygood added the red-knot Multi-file analysis & type inference label Nov 28, 2024
carljm added a commit that referenced this issue Dec 3, 2024
@InSyncWithFoo @carljm
[red-knot] Deeper understanding of LiteralString (#14649)
246a6df 
## Summary

Resolves #14648.

## Test Plan

Markdown tests.

---------

Co-authored-by: Carl Meyer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
red-knot Multi-file analysis & type inference
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[red-knot] Deeper understanding of LiteralString InSyncWithFoo/ruff
2 participants
@AlexWaygood @InSyncWithFoo