Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allowed-unused-imports has incorrect documentation #13668

Closed
tylerlaprade opened this issue Oct 7, 2024 · 5 comments · Fixed by #13677
Closed

allowed-unused-imports has incorrect documentation #13668

tylerlaprade opened this issue Oct 7, 2024 · 5 comments · Fixed by #13677
Labels
question Asking for support or clarification
Milestone

Comments

@tylerlaprade
Copy link
Contributor

  • In the docs, it's part of the lint section rather than lint.pyflakes
  • In those same docs, "thought" is used in place of "though"
  • The TOML schema doesn't recognize the setting at any of the three possible levels.
image
@zanieb
Copy link
Member

zanieb commented Oct 7, 2024

We should allow defining this either at lint or lint.pyflakes from my read of the code.
I presume the schema store has just not been updated since the last release.

Typo fix at #13669

@zanieb zanieb added the question Asking for support or clarification label Oct 7, 2024
@zanieb
Copy link
Member

zanieb commented Oct 7, 2024

@tylerlaprade
Copy link
Contributor Author

Thanks! Is there precedent for allowing other settings at two different levels? It seems a bit confusing.

@zanieb
Copy link
Member

zanieb commented Oct 8, 2024

I'm not sure honestly. It does seem confusing if it's not necessary for some reason. cc @charliermarsh who reviewed that contribution.

@charliermarsh
Copy link
Member

It should only be under lint.pyflakes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Asking for support or clarification
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants