ruff server: publishDiagnostics should be sent on onClose to clear diagnostics
#11114
Assignees
Labels
server
Related to the LSP server
Comments
snowsignal
added a commit
that referenced
this issue
Apr 25, 2024
…e cleared properly when a file is closed (#11137) ## Summary Fixes #11114. As part of the `onClose` handler, we publish an empty array of diagnostics for the document being closed, similar to [`ruff-lsp`](https://github.com/astral-sh/ruff-lsp/blob/187d7790be0783b9ac41ce025a724cf389bf575c/ruff_lsp/server.py#L459-L464). This prevent phantom diagnostics from lingering after a document is closed. We'll only do this if the client doesn't support pull diagnostics, because otherwise clearing diagnostics is their responsibility. ## Test Plan Diagnostics should no longer appear for a document in the Problems tab after the document is closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When clients don't support pull diagnostics, we'll need to send them an empty
publishDiagnosticsnotification when a file is closed - otherwise, the previous diagnostics for that file will continue to exist.Reported by @dhruvmanila here.
The text was updated successfully, but these errors were encountered: