Add some exceptions for FBT003 (#3247) (#4867)

astral-sh · Jun 13, 2023 · d933a58 · d933a58
1 parent 00cd6c4
commit d933a58
Show file tree

Hide file tree

Showing 4 changed files with 19 additions and 4 deletions.
diff --git a/crates/ruff/resources/test/fixtures/flake8_boolean_trap/FBT.py b/crates/ruff/resources/test/fixtures/flake8_boolean_trap/FBT.py
@@ -57,12 +57,16 @@ def used(do):
 {}.deploy(True, False)
 getattr(someobj, attrname, False)
 mylist.index(True)
+bool(False)
 int(True)
 str(int(False))
 cfg.get("hello", True)
 cfg.getint("hello", True)
 cfg.getfloat("hello", True)
 cfg.getboolean("hello", True)
+os.set_blocking(0, False)
+g_action.set_enabled(True)
+settings.set_enable_developer_extras(True)
 
 
 class Registry:

diff --git a/crates/ruff/src/rules/flake8_boolean_trap/helpers.rs b/crates/ruff/src/rules/flake8_boolean_trap/helpers.rs
@@ -10,6 +10,7 @@ pub(super) const FUNC_CALL_NAME_ALLOWLIST: &[&str] = &[
     "assertEquals",
     "assertNotEqual",
     "assertNotEquals",
+    "bool",
     "bytes",
     "count",
     "failIfEqual",
@@ -27,6 +28,8 @@ pub(super) const FUNC_CALL_NAME_ALLOWLIST: &[&str] = &[
     "param",
     "pop",
     "remove",
+    "set_blocking",
+    "set_enabled",
     "setattr",
     "__setattr__",
     "setdefault",

diff --git a/...flake8_boolean_trap/snapshots/ruff__rules__flake8_boolean_trap__tests__FBT001_FBT.py.snap b/...flake8_boolean_trap/snapshots/ruff__rules__flake8_boolean_trap__tests__FBT001_FBT.py.snap
@@ -81,12 +81,12 @@ FBT.py:19:5: FBT001 Boolean positional arg in function definition
 23 |     kwonly_nonvalued_nohint,
    |
 
-FBT.py:81:19: FBT001 Boolean positional arg in function definition
+FBT.py:85:19: FBT001 Boolean positional arg in function definition
    |
-81 |     # FBT001: Boolean positional arg in function definition
-82 |     def foo(self, value: bool) -> None:
+85 |     # FBT001: Boolean positional arg in function definition
+86 |     def foo(self, value: bool) -> None:
    |                   ^^^^^^^^^^^ FBT001
-83 |         pass
+87 |         pass
    |
 
 
diff --git a/...flake8_boolean_trap/snapshots/ruff__rules__flake8_boolean_trap__tests__FBT003_FBT.py.snap b/...flake8_boolean_trap/snapshots/ruff__rules__flake8_boolean_trap__tests__FBT003_FBT.py.snap
@@ -28,4 +28,12 @@ FBT.py:57:17: FBT003 Boolean positional value in function call
 61 | mylist.index(True)
    |
 
+FBT.py:69:38: FBT003 Boolean positional value in function call
+   |
+69 | os.set_blocking(0, False)
+70 | g_action.set_enabled(True)
+71 | settings.set_enable_developer_extras(True)
+   |                                      ^^^^ FBT003
+   |
+