Respect external codes in file-level exemptions

crates/ruff/tests/lint.rs

@@ -849,7 +849,7 @@ fn deprecated_config_option_overridden_via_cli() {
     success: false
     exit_code: 1
     ----- stdout -----
-    -:1:7: N801 Class name `lowercase` should use CapWords convention 
+    -:1:7: N801 Class name `lowercase` should use CapWords convention
     Found 1 error.
 
     ----- stderr -----
@@ -933,3 +933,42 @@ include = ["*.ipy"]
 
     Ok(())
 }
+
+#[test]
+fn file_noqa_external() -> Result<()> {
+    let tempdir = TempDir::new()?;
+    let ruff_toml = tempdir.path().join("ruff.toml");
+    fs::write(
+        &ruff_toml,
+        r#"
+[lint]
+external = ["AAA"]
+"#,
+    )?;
+
+    insta::with_settings!({
+        filters => vec![(tempdir_filter(&tempdir).as_str(), "[TMP]/")]
+    }, {
+    assert_cmd_snapshot!(Command::new(get_cargo_bin(BIN_NAME))
+        .args(STDIN_BASE_OPTIONS)
+        .arg("--config")
+        .arg(&ruff_toml)
+        .arg("-")
+        .pass_stdin(r#"
+# flake8: noqa: AAA101, BBB102
+import os
+"#), @r###"
+    success: false
+    exit_code: 1
+    ----- stdout -----
+    -:3:8: F401 [*] `os` imported but unused
+    Found 1 error.
+    [*] 1 fixable with the `--fix` option.
+
+    ----- stderr -----
+    warning: Invalid rule code provided to `# ruff: noqa` at -:2: BBB102
+    "###);
+    });
+
+    Ok(())
+}

crates/ruff_linter/src/checkers/noqa.rs

@@ -29,7 +29,13 @@ pub(crate) fn check_noqa(
     settings: &LinterSettings,
 ) -> Vec<usize> {
     // Identify any codes that are globally exempted (within the current file).
-    let exemption = FileExemption::try_extract(locator.contents(), comment_ranges, path, locator);
+    let exemption = FileExemption::try_extract(
+        locator.contents(),
+        comment_ranges,
+        &settings.external,
+        path,
+        locator,
+    );
 
     // Extract all `noqa` directives.
     let mut noqa_directives = NoqaDirectives::from_commented_ranges(comment_ranges, path, locator);

crates/ruff_linter/src/linter.rs

@@ -407,6 +407,7 @@ pub fn add_noqa_to_path(
         &diagnostics.0,
         &locator,
         indexer.comment_ranges(),
+        &settings.external,
         &directives.noqa_line_for,
         stylist.line_ending(),
     )

crates/ruff_linter/src/noqa.rs

@@ -235,6 +235,7 @@ impl FileExemption {
     pub(crate) fn try_extract(
         contents: &str,
         comment_ranges: &CommentRanges,
+        external: &[String],
         path: &Path,
         locator: &Locator,
     ) -> Option<Self> {
@@ -263,6 +264,13 @@ impl FileExemption {
                         }
                         ParsedFileExemption::Codes(codes) => {
                             exempt_codes.extend(codes.into_iter().filter_map(|code| {
+                                // Ignore externally-defined rules.
+                                if external
+                                .iter()
+                                .any(|external| code.starts_with(external)) {
+                                    return None;
+                                }
+
                                 if let Ok(rule) = Rule::from_code(get_redirect_target(code).unwrap_or(code))
                                 {
                                     Some(rule.noqa_code())
@@ -458,6 +466,7 @@ pub(crate) fn add_noqa(
     diagnostics: &[Diagnostic],
     locator: &Locator,
     comment_ranges: &CommentRanges,
+    external: &[String],
     noqa_line_for: &NoqaMapping,
     line_ending: LineEnding,
 ) -> Result<usize> {
@@ -466,6 +475,7 @@ pub(crate) fn add_noqa(
         diagnostics,
         locator,
         comment_ranges,
+        external,
         noqa_line_for,
         line_ending,
     );
@@ -478,6 +488,7 @@ fn add_noqa_inner(
     diagnostics: &[Diagnostic],
     locator: &Locator,
     comment_ranges: &CommentRanges,
+    external: &[String],
     noqa_line_for: &NoqaMapping,
     line_ending: LineEnding,
 ) -> (usize, String) {
@@ -487,7 +498,8 @@ fn add_noqa_inner(
 
     // Whether the file is exempted from all checks.
     // Codes that are globally exempted (within the current file).
-    let exemption = FileExemption::try_extract(locator.contents(), comment_ranges, path, locator);
+    let exemption =
+        FileExemption::try_extract(locator.contents(), comment_ranges, external, path, locator);
     let directives = NoqaDirectives::from_commented_ranges(comment_ranges, path, locator);
 
     // Mark any non-ignored diagnostics.
@@ -1001,6 +1013,7 @@ mod tests {
             &[],
             &Locator::new(contents),
             &CommentRanges::default(),
+            &[],
             &noqa_line_for,
             LineEnding::Lf,
         );
@@ -1021,6 +1034,7 @@ mod tests {
             &diagnostics,
             &Locator::new(contents),
             &CommentRanges::default(),
+            &[],
             &noqa_line_for,
             LineEnding::Lf,
         );
@@ -1048,6 +1062,7 @@ mod tests {
             &diagnostics,
             &Locator::new(contents),
             &comment_ranges,
+            &[],
             &noqa_line_for,
             LineEnding::Lf,
         );
@@ -1075,6 +1090,7 @@ mod tests {
             &diagnostics,
             &Locator::new(contents),
             &comment_ranges,
+            &[],
             &noqa_line_for,
             LineEnding::Lf,
         );