Update fix for literal-membership (PLR6201) to be unsafe (#8097)

Closes #8096
astral-sh · Oct 20, 2023 · 348b649 · 348b649
1 parent ae41d6f
commit 348b649
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 4 deletions.
diff --git a/crates/ruff_linter/src/rules/pylint/rules/literal_membership.rs b/crates/ruff_linter/src/rules/pylint/rules/literal_membership.rs
@@ -59,7 +59,10 @@ pub(crate) fn literal_membership(checker: &mut Checker, compare: &ast::ExprCompa
 
     let literal = checker.locator().slice(right);
     let set = format!("{{{}}}", &literal[1..literal.len() - 1]);
-    diagnostic.set_fix(Fix::safe_edit(Edit::range_replacement(set, right.range())));
+    diagnostic.set_fix(Fix::unsafe_edit(Edit::range_replacement(
+        set,
+        right.range(),
+    )));
 
     checker.diagnostics.push(diagnostic);
 }
diff --git a/...es/pylint/snapshots/ruff_linter__rules__pylint__tests__PLR6201_literal_membership.py.snap b/...es/pylint/snapshots/ruff_linter__rules__pylint__tests__PLR6201_literal_membership.py.snap
@@ -11,7 +11,7 @@ literal_membership.py:2:6: PLR6201 [*] Use a `set` literal when testing for memb
   |
   = help: Convert to `set`
 
-ℹ Fix
+ℹ Suggested fix
 1 1 | # Errors
 2   |-1 in [1, 2, 3]
   2 |+1 in {1, 2, 3}
@@ -30,7 +30,7 @@ literal_membership.py:3:6: PLR6201 [*] Use a `set` literal when testing for memb
   |
   = help: Convert to `set`
 
-ℹ Fix
+ℹ Suggested fix
 1 1 | # Errors
 2 2 | 1 in [1, 2, 3]
 3   |-1 in (1, 2, 3)
@@ -53,7 +53,7 @@ literal_membership.py:4:6: PLR6201 [*] Use a `set` literal when testing for memb
   |
   = help: Convert to `set`
 
-ℹ Fix
+ℹ Suggested fix
 1 1 | # Errors
 2 2 | 1 in [1, 2, 3]
 3 3 | 1 in (1, 2, 3)