Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better handle BOLT skipped tests #465

Closed
indygreg opened this issue Jan 1, 2025 · 0 comments · Fixed by #469
Closed

Better handle BOLT skipped tests #465

indygreg opened this issue Jan 1, 2025 · 0 comments · Fixed by #469
Assignees
@zanieb

Comments

@indygreg
Copy link
Collaborator

indygreg commented Jan 1, 2025

See discussion at #463 (review).

tl;dr we had to disable some tests to avoid segfaults when BOLTing. We ship those test disables as part of the distributions, which feels wrong.
@zanieb zanieb self-assigned this Jan 1, 2025
indygreg added a commit that referenced this issue Jan 2, 2025
@indygreg
unix: refresh test_embed patches to conditionally skip on BOLT
50c0317 
Turns out there is a support function to check for BOLT optimization.
So we can conditionally skip tests on BOLT.

Closes #465.
@indygreg indygreg mentioned this issue Jan 2, 2025
Merged
zanieb pushed a commit that referenced this issue Jan 3, 2025
@indygreg
unix: refresh test_embed patches to conditionally skip on BOLT (#469)
eed3a7f 
Turns out there is a support function to check for BOLT optimization. So
we can conditionally skip tests on BOLT.

Closes #465.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zanieb zanieb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

unix: refresh test_embed patches to conditionally skip on BOLT astral-sh/python-build-standalone
2 participants
@indygreg @zanieb