-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
alija/feature/webpack #37
base: master
Are you sure you want to change the base?
Conversation
…eir dependencies, unfinsihed)
…or subtle errors required.
… mocks, fix minor issues with source
…y dist folder content
We should probably configure |
When downloading a model and then trying to upload model again, there is an error message: The current release of http://asterics.github.io/AsTeRICS/webapps/WebACS/ does not throw that error. |
Please update README.md with build and run instructions |
I've encountered this problem too. But I don't believe it is caused by this PR. But I may be wrong. You need to connect all ports to be able to upload any model - apparently. I had this error too when working on dynamic properties. But this was before this PR. I'll test with pull/36 just to be sure. |
d666af7
to
72ef080
Compare
WebACS and most of the resources (css, images) are bundled now with
webpack
. Previous test were migrated fromQUnit
tojest
. (Almost) all functions of the WebACS were successfully tested manually. Working with it, creating models and deploying to/from ARE, starting/stopping models is working fine.Tests with jest were mocked were necessary (e.g. FileReader). Tests with
jquery-ui
are failing currently and were excluded and annotated. jquery-ui cannot be ingrated in current build setup. Until workaround (or solution) is found, test are to be excluded, and possibly replaced in future anyway.A multibranch-pipeline was setup at the Jenkins server, Jenkinsfile provides following steps: Cleanup, Build, Test, Deploy and results can now be downloaded from the server after a build (cf. here).
Jenkinsfile currently uses different agents, because zip utilities are not supported within node container. Following workarounds/solution were tested so far:
Pipeline Utility Steps
: Jenkins parameter error when using zip command (cf. here)File Operations Plugin
: worked, but zipped folder is placed inside another folder (cf. here)zip
command: current setup. this step should be changed eventually to support different environments (linux, mac, win)Dockerfile
: proposed. using a custom docker container (or Dockerfile), the zip package could be installed in the containerNotes:
Suggested next steps:
Additional notes: