Skip to content

Commit

Permalink
[TASK] Update for TYPO3 13.4 LTS
Browse files Browse the repository at this point in the history
  • Loading branch information
astehlik committed Oct 15, 2024
1 parent 0a19cc8 commit d084ccd
Show file tree
Hide file tree
Showing 5 changed files with 14 additions and 24 deletions.
2 changes: 1 addition & 1 deletion Classes/Controller/OembedController.php
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ private function getNextMatchingProvider(ProviderResolver $providerResolver, str
{
try {
return $providerResolver->getNextMatchingProvider($url);
} catch (NoMatchingProviderException $e) {
} catch (NoMatchingProviderException) {
return null;
}
}
Expand Down
19 changes: 9 additions & 10 deletions Classes/Request/RequestHandler/Panopto/PanoptoRequestHandler.php
Original file line number Diff line number Diff line change
Expand Up @@ -8,21 +8,20 @@
use Sto\Mediaoembed\Domain\Model\Provider;
use Sto\Mediaoembed\Request\RequestHandler\RequestHandlerInterface;
use TYPO3\CMS\Core\Utility\GeneralUtility;
use TYPO3\CMS\Fluid\View\StandaloneView;
use TYPO3\CMS\Core\View\ViewFactoryData;
use TYPO3\CMS\Core\View\ViewFactoryInterface;

final class PanoptoRequestHandler implements RequestHandlerInterface
final readonly class PanoptoRequestHandler implements RequestHandlerInterface
{
private PanoptoUrlProcessor $urlProcessor;

public function __construct(PanoptoUrlProcessor $urlProcessor)
{
$this->urlProcessor = $urlProcessor;
}
public function __construct(
private PanoptoUrlProcessor $urlProcessor,
private ViewFactoryInterface $viewFactory,
) {}

public function handle(Provider $provider, Configuration $configuration): array
{
$view = new StandaloneView();
$view->setTemplatePathAndFilename($this->getTemplatePath());
$viewFactoryData = new ViewFactoryData(templatePathAndFilename: $this->getTemplatePath());
$view = $this->viewFactory->create($viewFactoryData);

$settings = $provider->getRequestHandlerSettings();

Expand Down
8 changes: 0 additions & 8 deletions Classes/ViewHelpers/EmbedResponsivePaddingViewHelper.php
Original file line number Diff line number Diff line change
Expand Up @@ -17,14 +17,6 @@ public function initializeArguments(): void
$this->registerArgument('configuration', Configuration::class, '', true);
$this->registerArgument('response', AspectRatioAwareResponseInterface::class, '', true);
$this->registerArgument('style-property', 'string', '', false, 'padding-top');

$this->registerTagAttribute(
'class',
'string',
'CSS class(es) for this element',
false,
'tx-mediaoembed-embed-responsive-padding',
);
}

public function render(): string
Expand Down
5 changes: 2 additions & 3 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,14 +12,13 @@
"require": {
"php": "^8.2",
"ext-dom": "*",
"typo3/cms-core": "~13.2.1"
"typo3/cms-core": "~13.4.0"
},
"require-dev": {
"de-swebhosting/typo3-extension-buildtools": "dev-TYPO3_13",
"typo3/cms-filelist": "*",
"typo3/cms-fluid-styled-content": "*",
"typo3/cms-install": "*",
"typo3/testing-framework": "dev-main"
"typo3/cms-install": "*"
},
"replace": {
"typo3-ter/mediaoembed": "self.version"
Expand Down
4 changes: 2 additions & 2 deletions ext_emconf.php
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
'description' => 'External media (YouTube, Flickr, ...) content elements using the http://oembed.com/ standard.',
'category' => 'fe',
'constraints' => [
'depends' => ['typo3' => '13.2.1-13.2.99'],
'depends' => ['typo3' => '13.4.0-13.4.99'],
'conflicts' => [],
'suggests' => [],
],
Expand All @@ -21,5 +21,5 @@
'author' => 'Alexander Stehlik',
'author_email' => '[email protected]',
'author_company' => '',
'version' => '13.0.0-dev',
'version' => '13.4.0-dev',
];

0 comments on commit d084ccd

Please sign in to comment.