Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Livechat] Notify agents when a new chat is queued #503

Merged
merged 1 commit into from
Sep 13, 2018

Conversation

mrsimpson
Copy link
Member

@mrsimpson mrsimpson commented Sep 12, 2018

This PR adds a notification once a livechat guest arrives in a queue.
In contrast to previous behavior, this creates the notification only once, not for all messages.
After the chat has been taken by an agent, of course the notifications are effective as usual

@ghost ghost assigned mrsimpson Sep 12, 2018
@ghost ghost added the progress:working label Sep 12, 2018
@mrsimpson mrsimpson requested a review from a team September 12, 2018 15:40
Copy link

@ruKurz ruKurz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks strait forward. I'd like to test the notifications on a CI environment before approving this PR.

Copy link

@ruKurz ruKurz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested locally

@ruKurz ruKurz merged commit cba977f into develop Sep 13, 2018
@ghost ghost removed the progress:working label Sep 13, 2018
@mrsimpson mrsimpson deleted the fix/livechat-notifications-guest-pool branch December 7, 2020 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants