Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

changing the run webdriver manager to run e2e tests #304

Closed
wants to merge 1 commit into from
Closed

changing the run webdriver manager to run e2e tests #304

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,13 +14,12 @@
"lint": "eslint *.js src/ config/ --fix",
"test": "npm run test:unit && npm run test:e2e",
"pretest:e2e": "npm run build",
"test:e2e": "protractor config/protractor.conf.js",
"test:e2e": "npm run webdriver && protractor config/protractor.conf.js",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of calling the webdriver task here you should have used the ci task. Because running the webdriver task every time you run the e2e task will make development really slow.

"test:unit": "karma start config/karma.conf.js --single-run",
"test:unit:watch": "karma start config/karma.conf.js --auto-watch",
"prepare": "npm run build",
"release": "standard-version",
"webdriver": "webdriver-manager update",
"postinstall": "npm run webdriver"
"webdriver": "webdriver-manager update"
},
"keywords": [
"input",
Expand Down