fix(uiPercentageMask): honor ui-hide-space when view value change due… #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to model update from controller Previously, a change to the model in the controller would result in a space in between the percent sign and the value no matter if the ui-hide-space attribute is present or not. Now, a change to the model will result in the correct view value format. Non-breaking change.
… to model update from controller Add missing mock inject in the new test. Non-breaking change.
|
Thank you for the pull request. |
… to model update from controller Update failing tests. When accessing via rootScope, update model to 50 not 0.5 to represent 50%. Non-breaking change.
|
@assisrafael I've updated the karma test to fix the issue. I apologize for not doing it sooner. All tests are now passing. |
|
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… to model update from controller
Previously, a change to the model in the controller would result in a space in between the percent sign and the value no matter if the ui-hide-space attribute is present or not. Now, a change to the model will result in the correct view value format.
Non-breaking change.