changing the run webdriver manager to run e2e tests #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
assisrafael
reviewed
Oct 11, 2017
| @@ -14,13 +14,12 @@ | |||
| "lint": "eslint *.js src/ config/ --fix", | |||
| "test": "npm run test:unit && npm run test:e2e", | |||
| "pretest:e2e": "npm run build", | |||
| "test:e2e": "protractor config/protractor.conf.js", | |||
| "test:e2e": "npm run webdriver && protractor config/protractor.conf.js", | |||
There was a problem hiding this comment.
Instead of calling the webdriver task here you should have used the ci task. Because running the webdriver task every time you run the e2e task will make development really slow.
|
Thank you for the pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed webdriver-manager from postinstall, and added to the "test:e2e" instruction. Changing, because "npm install --prod" not working, and broke installation for the production enviroment only.