Building v5.1.6 gives error: 'zlib_filefunc_def' {aka 'struct zlib_filefunc_def_s'} has no member named 'zopendisk_file' #4334

brechtsanders · 2022-01-10T08:33:05Z

Building v5.1.6 gives error: 'zlib_filefunc_def' {aka 'struct zlib_filefunc_def_s'} has no member named 'zopendisk_file'.

I'm on Windows 11 using MinGW-w64 GCC 11.2.0 and I have all dependancies installed from latest versions.

Whe building assimp 5.1.6 I get:

R:/winlibs64-11.2.0ucrt/assimp-5.1.6/code/Common/ZipArchiveIOSystem.cpp: In static member function 'static zlib_filefunc_def Assimp::IOSystem2Unzip::get(Assimp::IOSystem*)':
R:/winlibs64-11.2.0ucrt/assimp-5.1.6/code/Common/ZipArchiveIOSystem.cpp:200:13:
error: 'zlib_filefunc_def' {aka 'struct zlib_filefunc_def_s'} has no member named 'zopendisk_file'; did you mean 'zopen_file'?
  200 |     mapping.zopendisk_file = (opendisk_file_func)opendisk;
      |             ^~~~~~~~~~~~~~
      |             zopen_file
R:/winlibs64-11.2.0ucrt/assimp-5.1.6/code/Common/ZipArchiveIOSystem.cpp:200:31:
error: 'opendisk_file_func' was not declared in this scope; did you mean 'open_file_func'?
  200 |     mapping.zopendisk_file = (opendisk_file_func)opendisk;
      |                               ^~~~~~~~~~~~~~~~~~
      |                               open_file_func
ninja: build stopped: subcommand failed.

When checking I noticed there are different ioapi.h versions around with and without zopendisk_file defined as member of zlib_filefunc_def_s. From what I see I think ZOPENDISK64 seems like a good macro to check to determine if zopendisk_file is to be used or not.

So I was able to build assimp 5.1.6 after the following patch:

patch -ulbf code/Common/ZipArchiveIOSystem.cpp << EOF
@@ -198,3 +198,5 @@
     mapping.zopen_file = (open_file_func)open;
+#ifdef ZOPENDISK64
     mapping.zopendisk_file = (opendisk_file_func)opendisk;
+#endif
     mapping.zread_file = (read_file_func)read;
EOF

But I'm not sure if that breaks anything else...

The text was updated successfully, but these errors were encountered:

ryandesign · 2022-01-10T20:16:59Z

I have essentially the same problem trying to build assimp 5.1.6 on macOS 10.15.7:

code/Common/ZipArchiveIOSystem.cpp:199:50: error: expected ';' after expression
    mapping.zopendisk_file = (opendisk_file_func)opendisk;
                                                 ^
                                                 ;
code/Common/ZipArchiveIOSystem.cpp:199:13: error: no member named 'zopendisk_file' in 'zlib_filefunc_def_s'
    mapping.zopendisk_file = (opendisk_file_func)opendisk;
    ~~~~~~~ ^
code/Common/ZipArchiveIOSystem.cpp:199:31: error: use of undeclared identifier 'opendisk_file_func'
    mapping.zopendisk_file = (opendisk_file_func)opendisk;
                              ^
code/Common/ZipArchiveIOSystem.cpp:199:50: error: expression result unused [-Werror,-Wunused-value]
    mapping.zopendisk_file = (opendisk_file_func)opendisk;
                                                 ^~~~~~~~
4 errors generated.

assimp 5.1.5 didn't have this problem.

VladyslavTupikin · 2022-01-12T23:43:37Z

Hi, i have the same issue on Arch Linux

gcc (GCC) 11.1.0

   Static hostname: dkpc
         Icon name: computer-desktop
           Chassis: desktop
        Machine ID: a94ff1b5f37a4868a87465dccbce1a1e
           Boot ID: 1bbc8f538be14e04aa409fc74c8f2ff8
  Operating System: Arch Linux
            Kernel: Linux 5.11.8-arch1-1
      Architecture: x86-64

/home/dk/soft/assimp/code/Common/ZipArchiveIOSystem.cpp: In static member function ‘static zlib_filefunc_def Assimp::IOSystem2Unzip::get(Assimp::IO
System*)’:                                                               
/home/dk/soft/assimp/code/Common/ZipArchiveIOSystem.cpp:199:13: error: ‘zlib_filefunc_def’ {aka ‘struct zlib_filefunc_def_s’} has no member named ‘
zopendisk_file’; did you mean ‘zopen_file’?                                                                                                        
  199 |     mapping.zopendisk_file = (opendisk_file_func)opendisk;
      |             ^~~~~~~~~~~~~~
      |             zopen_file
/home/dk/soft/assimp/code/Common/ZipArchiveIOSystem.cpp:199:31: error: ‘opendisk_file_func’ was not declared in this scope; did you mean ‘open_file
_func’?                                                                  
  199 |     mapping.zopendisk_file = (opendisk_file_func)opendisk;                                                                                 
      |                               ^~~~~~~~~~~~~~~~~~
      |                               open_file_func
[  5%] Building CXX object code/CMakeFiles/assimp.dir/Common/Subdivision.cpp.o
[  6%] Building CXX object code/CMakeFiles/assimp.dir/Common/scene.cpp.o
make[2]: *** [code/CMakeFiles/assimp.dir/build.make:186: code/CMakeFiles/assimp.dir/Common/ZipArchiveIOSystem.cpp.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [CMakeFiles/Makefile2:182: code/CMakeFiles/assimp.dir/all] Error 2
make: *** [Makefile:149: all] Error 2

kimkulling · 2022-01-13T19:18:16Z

Pretty bad, thanks for the report. We will take care.

umlaeute · 2022-01-19T09:04:55Z

and of course we have a similar problem for the Debian packages...

however, i'm a bit confused.

i see that the unzip implementation in contrib/ does provide the missing typedefs and struct members.
now, in Debian we make sure to use system libraries instead of vendored libraries (completely ditching contrib/unzip/) and the libminizip-dev system library does not provide the typedefs/members.

however, i would have thought that "ordinary builds" (that is: what practically every user who downloads the assimp sources and builds them would do) would use the vendored library...

and why is the CI building successfully?

anyhow:
it seems this is yet another problem with #3556 (Update unzip contrib), similar to #3591

it's a bit unfortunate that #3556 updated the "unzip contrib" without mentioning where the sources actually came from.

luckily there's also #4324, where @alpire hints that these changes come

from https://github.com/hunter-packages/minizip. That repo itself is an old fork of minizip-ng. minizip-ng removed zopendisk_file in 2017.

i suggest to stay compatible with mainstream implementations (rather than some unmaintained forks)
(and possibly open some issue with the hunter packages)

tkircher · 2022-01-23T06:45:01Z

I also ran into this issue, on a clean Ubuntu 20.04.3 LTS system with the relevant system libraries installed. There seem to be numerous projects these days building their own incompatible versions of very common system libraries instead of fixing the code.

derenv · 2022-02-10T16:28:57Z

also ran into this problem on manjaro! patch from @brechtsanders solved it however.

yurivict · 2022-02-21T22:21:51Z

@derenv How did you solve it?

ryandesign · 2022-02-21T22:23:10Z

He used the patch he provided in the last block of code in this bug report.

derenv · 2022-02-21T22:48:45Z

@derenv How did you solve it?

i used @brechtsanders patch he put in the original post.

waebbl · 2022-03-11T09:26:51Z

I'm having the same issue on Gentoo Linux while packaging for v5.2.2.
@brechtsanders patch lets the package build, but I'm not sure if it's the right check. The check for ZOPENDISK64 looks like it would pass for zlib_filefunc64_def_s, but seems inappropriate for the zlib_filefunc_def_s struct where it should look more like ZOPENDISK IMO.

larryxiao625 · 2022-03-11T09:27:13Z

这是来自QQ邮箱的自动回复邮件。你的邮件已经收到，我将在尽快给你回复。

umlaeute · 2022-03-11T10:11:59Z

@ray804 broken chinese autoreply?

@waebbl well, applying the patch allows me to build assimp (which of course is necessary) and the testsuite passes (which i think is a good indication that the fix is also sufficient).

waebbl · 2022-03-11T11:44:46Z

@waebbl well, applying the patch allows me to build assimp (which of course is necessary) and the testsuite passes (which i think is a good indication that the fix is also sufficient).

Almost same here, so I consider it a good hack. There are a few tests, however, which are failing on my side.
For proper handling by upstream devs, I think the fix should be checked more thoroughly.

Removes the doc USE flag, because the documentation is no longer available as a pdf on the release page and building it is currently broken. Bug: assimp/assimp#4439 Bug: assimp/assimp#4438 Bug: assimp/assimp#4334 Bug: https://bugs.gentoo.org/830374 Closes: https://bugs.gentoo.org/829957 Package-Manager: Portage-3.0.30, Repoman-3.0.3 Signed-off-by: Bernd Waibel <[email protected]>

MarkCallow · 2022-03-12T07:27:52Z

I have the same issue trying to build master or 5.2.2 on macOS Monterey with Xcode 13.2. I find it difficult to have confidence to use a project where a bug that prevents building is still not fixed after 2 months.

tkircher · 2022-03-12T07:53:51Z

I have the same issue trying to build master or 5.2.2 on macOS Monterey with Xcode 13.2. I find it difficult to have confidence to use a project where a bug that prevents building is still not fixed after 2 months.

No worries, you can have your money back

Removes the doc USE flag, because the documentation is no longer available as a pdf on the release page and building it is currently broken. Bug: assimp/assimp#4439 Bug: assimp/assimp#4438 Bug: assimp/assimp#4334 Bug: https://bugs.gentoo.org/830374 Closes: https://bugs.gentoo.org/829957 Package-Manager: Portage-3.0.30, Repoman-3.0.3 Signed-off-by: Bernd Waibel <[email protected]> Closes: #24485 Signed-off-by: Matthew Smith <[email protected]>

feliwir · 2022-03-23T14:19:17Z

I hit the same issue after switching from Debian to Arch - i guess a newer zlib version causes that issue?

umlaeute · 2022-03-23T14:53:49Z

No. The issue is a completely outdated (and unmaintained) fork of zlib that somehow made it into a c++-package manager (that is used by assimp); that version of zlib is not packaged in any other distribution...

brechtsanders · 2022-03-23T16:04:45Z

My build environment is using all latest versions built from source. For zlib this is version 1.2.11 from http://www.zlib.net/.

feliwir · 2022-03-24T09:46:29Z

@umlaeute i'm definetly not using HUNTER if you refer to that. I'm using the latest Arch Linux and this error occured after switching from Ubuntu 20.04 - i assume this is due to some dependency update

danielk333 · 2022-05-19T06:27:23Z

Having the same issue on Manjaro on commit 4d451fe

Edit: building works on v5.1.0

larryxiao625 · 2022-05-19T06:27:46Z

这是来自QQ邮箱的自动回复邮件。你的邮件已经收到，我将在尽快给你回复。

lucasjinreal · 2022-05-27T05:26:11Z

Got same issue on gcc11 on a refresh Ubuntu 22.04. Although this PC can sucessfully built before uprade to ubuntu22.04.

Does there any quick fix for it? cause it was about 5 month past....

onurtore · 2022-06-16T08:50:14Z

You can also try to remove the line:
mapping.zopendisk_file = (opendisk_file_func)opendisk;

Apperantly this also works.

larryxiao625 · 2022-06-16T08:50:39Z

这是来自QQ邮箱的自动回复邮件。你的邮件已经收到，我将在尽快给你回复。

robertosfield · 2022-07-08T14:22:17Z

I hit upon this issue on Kubuntu 21.10, I've submitted PR that fixes the build, albeit with a crude #ifdef to avoid the problematic line build compiled when building against minizip. #4631

kimkulling · 2022-07-08T18:55:43Z

Closed by #4631

brechtsanders added the Bug Global flag to mark a deviation from expected behaviour label Jan 10, 2022

kimkulling added the Build Global flag to mark build relates topics label Jan 13, 2022

ryandesign mentioned this issue Feb 21, 2022

5.2.0: Build fails: error: expected ';' after expression #4374

Open

waebbl mentioned this issue Mar 11, 2022

media-libs/assimp: bump to 5.2.2 gentoo/gentoo#24485

Closed

K1ngst0m mentioned this issue Apr 19, 2022

Bug: minizip building issue on gentoo #4492

Open

onurtore mentioned this issue Jun 1, 2022

Analysis of external mesh loading libraries and comparison with the existing approach gazebosim/gz-common#344

Open

turol mentioned this issue Jun 27, 2022

Bug:Failed to build assimp from source #4591

Closed

robertosfield mentioned this issue Jul 8, 2022

Build fix for compiling against minizip. #4631

Merged

kimkulling closed this as completed Jul 8, 2022

kimkulling moved this to Todo in Asset-Importer-Lib Development Sep 13, 2022

kimkulling added this to Asset-Importer-Lib Development Sep 13, 2022

kimkulling added this to The Asset-Importer-Lib Kanban Board Sep 21, 2022

kimkulling removed this from The Asset-Importer-Lib Kanban Board Sep 21, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Building v5.1.6 gives error: 'zlib_filefunc_def' {aka 'struct zlib_filefunc_def_s'} has no member named 'zopendisk_file' #4334

Building v5.1.6 gives error: 'zlib_filefunc_def' {aka 'struct zlib_filefunc_def_s'} has no member named 'zopendisk_file' #4334

brechtsanders commented Jan 10, 2022

ryandesign commented Jan 10, 2022

VladyslavTupikin commented Jan 12, 2022 •

edited

Loading

kimkulling commented Jan 13, 2022

umlaeute commented Jan 19, 2022

tkircher commented Jan 23, 2022

derenv commented Feb 10, 2022

yurivict commented Feb 21, 2022

ryandesign commented Feb 21, 2022

derenv commented Feb 21, 2022

waebbl commented Mar 11, 2022

larryxiao625 commented Mar 11, 2022 via email

umlaeute commented Mar 11, 2022

waebbl commented Mar 11, 2022 •

edited

Loading

MarkCallow commented Mar 12, 2022

tkircher commented Mar 12, 2022

feliwir commented Mar 23, 2022

umlaeute commented Mar 23, 2022 •

edited

Loading

brechtsanders commented Mar 23, 2022

feliwir commented Mar 24, 2022 •

edited

Loading

danielk333 commented May 19, 2022 •

edited

Loading

larryxiao625 commented May 19, 2022 via email

lucasjinreal commented May 27, 2022

onurtore commented Jun 16, 2022 •

edited

Loading

larryxiao625 commented Jun 16, 2022 via email

robertosfield commented Jul 8, 2022

kimkulling commented Jul 8, 2022

Building v5.1.6 gives error: 'zlib_filefunc_def' {aka 'struct zlib_filefunc_def_s'} has no member named 'zopendisk_file' #4334

Building v5.1.6 gives error: 'zlib_filefunc_def' {aka 'struct zlib_filefunc_def_s'} has no member named 'zopendisk_file' #4334

Comments

brechtsanders commented Jan 10, 2022

ryandesign commented Jan 10, 2022

VladyslavTupikin commented Jan 12, 2022 • edited Loading

kimkulling commented Jan 13, 2022

umlaeute commented Jan 19, 2022

tkircher commented Jan 23, 2022

derenv commented Feb 10, 2022

yurivict commented Feb 21, 2022

ryandesign commented Feb 21, 2022

derenv commented Feb 21, 2022

waebbl commented Mar 11, 2022

larryxiao625 commented Mar 11, 2022 via email

umlaeute commented Mar 11, 2022

waebbl commented Mar 11, 2022 • edited Loading

MarkCallow commented Mar 12, 2022

tkircher commented Mar 12, 2022

feliwir commented Mar 23, 2022

umlaeute commented Mar 23, 2022 • edited Loading

brechtsanders commented Mar 23, 2022

feliwir commented Mar 24, 2022 • edited Loading

danielk333 commented May 19, 2022 • edited Loading

larryxiao625 commented May 19, 2022 via email

lucasjinreal commented May 27, 2022

onurtore commented Jun 16, 2022 • edited Loading

larryxiao625 commented Jun 16, 2022 via email

robertosfield commented Jul 8, 2022

kimkulling commented Jul 8, 2022

VladyslavTupikin commented Jan 12, 2022 •

edited

Loading

waebbl commented Mar 11, 2022 •

edited

Loading

umlaeute commented Mar 23, 2022 •

edited

Loading

feliwir commented Mar 24, 2022 •

edited

Loading

danielk333 commented May 19, 2022 •

edited

Loading

onurtore commented Jun 16, 2022 •

edited

Loading