Skip to content

Commit

Permalink
Merge pull request #127 from epage/template
Browse files Browse the repository at this point in the history
chore: Update from _rust template
  • Loading branch information
epage authored Sep 27, 2024
2 parents d5a21e1 + 00cd59d commit 041987e
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 4 deletions.
2 changes: 2 additions & 0 deletions .github/workflows/pre-commit.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,4 +24,6 @@ jobs:
steps:
- uses: actions/checkout@v4
- uses: actions/setup-python@v5
with:
python-version: '3.x'
- uses: pre-commit/[email protected]
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ We ask that commits are atomic, meaning they are complete and have a single resp
PRs should tell a cohesive story, with test and refactor commits that keep the
fix or feature commits simple and clear.

Specifically, we would encouage
Specifically, we would encourage
- File renames be isolated into their own commit
- Add tests in a commit before their feature or fix, showing the current behavior.
The diff for the feature/fix commit will then show how the behavior changed,
Expand Down
1 change: 1 addition & 0 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,7 @@ string_lit_as_bytes = "warn"
string_to_string = "warn"
todo = "warn"
trait_duplication_in_bounds = "warn"
uninlined_format_args = "warn"
verbose_file_reads = "warn"
wildcard_imports = "warn"
zero_sized_map_values = "warn"
Expand Down
6 changes: 3 additions & 3 deletions src/assert.rs
Original file line number Diff line number Diff line change
Expand Up @@ -470,23 +470,23 @@ mod test {
fn into_path_from_pred() {
let pred = convert_path(predicate::eq(path::Path::new("hello.md")));
let case = pred.find_case(false, path::Path::new("hello.md"));
println!("Failing case: {:?}", case);
println!("Failing case: {case:?}");
assert!(case.is_none());
}

#[test]
fn into_path_from_bytes() {
let pred = convert_path(b"hello\n" as &[u8]);
let case = pred.find_case(false, path::Path::new("tests/fixture/hello.txt"));
println!("Failing case: {:?}", case);
println!("Failing case: {case:?}");
assert!(case.is_none());
}

#[test]
fn into_path_from_str() {
let pred = convert_path("hello\n");
let case = pred.find_case(false, path::Path::new("tests/fixture/hello.txt"));
println!("Failing case: {:?}", case);
println!("Failing case: {case:?}");
assert!(case.is_none());
}
}

0 comments on commit 041987e

Please sign in to comment.