-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Obsidian integration #186
Open
Di3mex
wants to merge
9
commits into
assafelovic:master
Choose a base branch
from
Di3mex:obsidian-integration
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Obsidian integration #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat(client/index.html, client/scripts.js): add "Send to Obsidian" button to export research reports to Obsidian feat(config/config.py): add OBSIDIAN_TOKEN environment variable to store Obsidian API token feat(main.py): add POST endpoint /obsidian to send research reports to Obsidian
…assignment fix(main.py): ensure base_url ends with a forward slash to avoid URL concatenation issues fix(main.py): remove unnecessary whitespace before url variable assignment
Disable buttons before research is generated.
Gives ability to generate consecutive obsidian exports.
My PR includes a minor change in that the |
Thank you @Di3mex for this awesome contribution, let us review it in the coming week and update. It holds great potential but will require additional installation steps from users, so we need to consider how to best structure it. |
also @Di3mex please see conflicts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My workflow
Asking the question
Export to Obsidian
Read and continue
Implementation
Key points
Details
Limitations
Outlook
OBSIDIAN_AUTO_EXPORT=true
.