fix ucb lcb sign error

aspuru-guzik-group · Aug 2, 2023 · 27f3e03 · 27f3e03
1 parent be04ae8
commit 27f3e03
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/atlas/acquisition_functions/acqfs.py b/src/atlas/acquisition_functions/acqfs.py
@@ -362,7 +362,7 @@ def __init__(self, reg_model, cla_model, cla_likelihood=None, **acqf_args):
     def evaluate(self, X: torch.Tensor):
         posterior = self.reg_model.posterior(X=X)
         mean, sigma = self.compute_mean_sigma(posterior)
-        acqf_val = mean - self.beta.sqrt() * sigma
+        acqf_val = -mean - self.beta.sqrt() * sigma
         return acqf_val
 
 
@@ -376,7 +376,7 @@ def __init__(self, reg_model, cla_model, cla_likelihood, **acqf_args):
     def evaluate(self, X: torch.Tensor):
         posterior = self.reg_model.posterior(X=X)
         mean, sigma = self.compute_mean_sigma(posterior)
-        acqf_val = mean + self.beta.sqrt() * sigma
+        acqf_val = -mean + self.beta.sqrt() * sigma
         return acqf_val
 
 

diff --git a/src/atlas/base/base.py b/src/atlas/base/base.py
@@ -616,7 +616,7 @@ def cla_surrogate(
                     sample_x.append(float(element))
             X_proc.append(sample_x)
 
-        X_proc = torch.tensor(np.array(X_proc, **tkwargs))
+        X_proc = torch.tensor(np.array(X_proc), **tkwargs)
 
         if (
             self.problem_type == "fully_categorical"