Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for HTML 5 formaction & formmethod and buttons out of a form #38

Closed
wants to merge 3 commits into from

Conversation

Net-IT-Jonathan
Copy link

Please review these changes.

These where made to support formaction and formmethod on buttons.

@dnfclas
Copy link

dnfclas commented Jun 18, 2018

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

❌ Net-IT-Jonathan sign now
You have signed the CLA already but the status is still pending? Let us recheck it.

@mkArtakMSFT
Copy link
Member

Thanks for your effort, @Net-IT-Jonathan.
To consider a PR, we first need an associated issue. Can you please link this to one you're trying to resolve?
Our team triages the issues first and that's how we decide whether we need/want a change or not. If so, then only we'd look into PRs associated to those issues.

@mkArtakMSFT
Copy link
Member

Ok, found the referenced issue: #40

@mkArtakMSFT
Copy link
Member

And it looks like there was no response to a question we've asked. As the issue was closed we're going to close this PR too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants