This repository has been archived by the owner on Dec 18, 2017. It is now read-only.
correct the fallback order for runtime.json #2893
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -229,8 +229,8 @@ public RestoreCommand(FrameworkName fallbackFramework) | |||
| .Where(x => x.Severity == DiagnosticMessageSeverity.Error) | |||
| .Select(x => x.Message); | |||
|
|
|||
| throw new InvalidOperationException(errorMessages.Any() ? | |||
| $"Errors occured when while parsing project.json:{Environment.NewLine}{string.Join(Environment.NewLine, errorMessages)}" : | |||
| throw new InvalidOperationException(errorMessages.Any() ? | |||
There was a problem hiding this comment.
Just fallout from running Ctrl-K Ctrl-D :)
|
Travis only failed on OSX and it was because of a fix I made in dev that needs to be ported here. |
|
Add a test. The fact that we have no coverage doesn't inspire confidence 😄 |
|
Adding much more than a mocked-up unit test is going to take a significant effort, so it depends on when we need to get this in. |
|
I'll build a unit test to start with. We can see what that looks like |
|
Added a unit test. |
analogrelay
force-pushed
the
anurse/2891-runtime-fallback-order
branch
from
b035752
to
b7f196a
Compare
|
ping @davidfowl |
|
|
|
Merged |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2891
/cc @Eilon @muratg @davidfowl @DamianEdwards @danroth27 @BrennanConroy