This repository has been archived by the owner on Dec 18, 2017. It is now read-only.
fix #2811 by updating RID synthesis #2812
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
but let Pawel look first
|
🚢🇮🇹 |
|
You guys beat |
| @@ -182,6 +182,11 @@ private static Result InitializeCore(ApplicationHostContext context) | |||
| if (lockFileLookup != null) | |||
| { | |||
| var target = SelectTarget(context, context.LockFile); | |||
| if (Logger.IsEnabled && string.IsNullOrEmpty(target.RuntimeIdentifier)) | |||
| { | |||
| // REVIEW(anurse): Is there ever a reason we want to use the RID-less target now? | |||
There was a problem hiding this comment.
@davidfowl see this question. Thoughts?
|
I actually think tests need to be updated... |
analogrelay
force-pushed
the
anurse/2811-rids-are-broken
branch
from
02ded41
to
99ead04
Compare
|
@moozzyk Should have them all updated now. |
|
👍 |
analogrelay
force-pushed
the
anurse/2811-rids-are-broken
branch
from
99ead04
to
91bfcb2
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2811
I'm not sure there's a reliable way to test this unfortunately...
/cc @muratg @davidfowl @moozzyk @BrennanConroy