This repository has been archived by the owner on Dec 18, 2017. It is now read-only.
Indicate the beginning of executed scripts #1942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, though I wonder "in project.json" part is useful or not. I assume there won't be other DNX pieces which will execute scripts. I think we can check-in like this, and revisit later. |
| @@ -23,6 +30,8 @@ public bool Execute(Runtime.Project project, string scriptName, Func<string, str | |||
| return true; | |||
| } | |||
|
|
|||
| Report.WriteLine($"Executing script '{scriptName}' in {Runtime.Project.ProjectFileName}"); | |||
There was a problem hiding this comment.
Report can be null. Need to use Report?.WriteLine(...)
ChengTian
force-pushed
the
wei/show-executed-scripts
branch
from
98c5383
to
0d033fd
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
parent #1764
@balachir @muratg @davidfowl
Sample output:
