This repository has been archived by the owner on Dec 18, 2017. It is now read-only.
#1688: When resolve assembly from GAC compare version #1699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
Please review: @davidfowl @anurse @BrennanConroy @victorhurdugaci |
|
Looks good, ⌚ tests |
troydai
changed the title
|
/cc @victorhurdugaci Looks like the |
|
Ran the tests locally on Mac, they're indeed skipped. |
|
OSSkipCondition should probably use "Linux" instead of "Unix" |
|
Ya I know, I'm talking about the internals of the class |
troydai
force-pushed
the
trdai/1688
branch
2 times, most recently
from
9b7fcd2
to
274d035
Compare
| public class GacDependencyResolverFacts | ||
| { | ||
| [ConditionalTheory] | ||
| [OSSkipCondition(OperatingSystems.MacOSX | OperatingSystems.Linux)] |
|
Ping @davidfowl Sign off? |
| public class GacDependencyResolverFacts | ||
| { | ||
| [ConditionalTheory] | ||
| [FrameworkSkipCondition(RuntimeFrameworks.Mono)] |
There was a problem hiding this comment.
Why did you remove the other conditional?
|
Re reun the build |
|
/cc @davidfowl rebased |
|
@troydai, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR. |
|
|
|
I'll merge this change as soon as the CI passes. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue #1688
I'm adding tests right now.