This repository has been archived by the owner on Dec 18, 2017. It is now read-only.
Low hanging fruit performance improvements from profiling session #1167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
| @@ -443,7 +443,7 @@ private static IEnumerable<string> GetSourcePatternCore(JObject rawProject, stri | |||
| } | |||
|
|
|||
| // Assume it's an array (it should explode if it's not) | |||
| return token.ToObject<string[]>().SelectMany(GetSourcesSplit); | |||
| return token.Select(t => t.Value<string>()).SelectMany(GetSourcesSplit); | |||
There was a problem hiding this comment.
Lets add an extension method, ValueAsArray:
script.Value.Select(s => s.Value<string>()).ToArray()script.ValueAsArray<string>()You can have an overload that takes a property name as well:
foo["something"]?.ValueAsArray<string>()There was a problem hiding this comment.
And use it everywhere there's a ToObject<string[]>
There was a problem hiding this comment.
Sure. I'll update the PR with this feedback.
added 4 commits
February 5, 2015 09:53
This PR addresses the below bullet from this bug: #1147 Don't use Tracing system for logging, use Console.WriteLine for now. Trace loads the entire configuration stack.
This is to address the following bullet on bug : #1147 Don't use ToObject when parsing global/project.json, that causes the data contract serialization stack to load in JSON.NET which isn't required at all.
|
@davidfowl Updated PR. |
| globalSettings.ProjectSearchPaths = projectSearchPaths == null ? new string[] { } : projectSearchPaths.ToObject<string[]>(); | ||
| globalSettings.ProjectSearchPaths = projectSearchPaths == null ? | ||
| new string[] { } : | ||
| projectSearchPaths.Select(p => p.Value<string>()).ToArray(); |
|
/CC @muratg |
| { | ||
| public static T[] ValueAsArray<T>(this JToken jToken) | ||
| { | ||
| return jToken.Select(a => a.Value<T>()).ToArray(); |
There was a problem hiding this comment.
All callers handle the null here. But it wouldn't hurt adding a null check.
|
|
1 similar comment
|
|
|
merged : f748be5 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the below bullet from this bug: #1147
Don't use Tracing system for logging, use Console.WriteLine for now. Trace loads the entire configuration stack.
@davidfowl