Skip to content
This repository has been archived by the owner on Dec 18, 2017. It is now read-only.

Add PluginHandler support for IPlugin Protocols #1905

Closed
NTaylorMullen opened this issue May 19, 2015 · 1 comment
Closed

Add PluginHandler support for IPlugin Protocols #1905

NTaylorMullen opened this issue May 19, 2015 · 1 comment
Assignees
@NTaylorMullen
Labels
3 - Done enhancement
Milestone
1.0.0-beta5

Comments

@NTaylorMullen
Copy link
Member

PluginHandler should support resolving an active protocol for registered IPlugins. This also involves updating the IPlugin signature to contain protocol based information for the PluginHandler to use/set.
@NTaylorMullen NTaylorMullen self-assigned this May 19, 2015
@NTaylorMullen NTaylorMullen added this to the 1.0.0-beta5 milestone May 19, 2015
NTaylorMullen added a commit that referenced this issue May 20, 2015
@NTaylorMullen
Add IPlugin protocol to PluginHandler.
b009328 
- When a plugin is registered with the system a client protocol can now be provided. This protocol is then cross checked with the created IPlugin's protocol and the result of Register returns the Protocol that will be used when communicating with the registered Plugin.
- Added tests to validate error conditions and protocol resolutions.

#1905
@NTaylorMullen NTaylorMullen mentioned this issue May 20, 2015
Merged
NTaylorMullen added a commit that referenced this issue May 21, 2015
@NTaylorMullen
Add IPlugin protocol to PluginHandler.
df42027 
- When a plugin is registered with the system a client protocol can now be provided. This protocol is then cross checked with the created IPlugin's protocol and the result of Register returns the Protocol that will be used when communicating with the registered Plugin.
- Added tests to validate error conditions and protocol resolutions.

#1905
NTaylorMullen added a commit to aspnet/RazorTooling that referenced this issue May 21, 2015
@NTaylorMullen
React to aspnet/dnx#1905 and aspnet/dnx#1906.
c9f771e 
- Removed PluginProtocolMessage because it's now handled by the PluginHandler in the DTH.
- Updated ProcessMessage to match the new IPlugin contract. This included indicating if a message was handled or not via the return message.
- Removed PluginProtocolMessage tests.
- Added handled checking to existing tests.
NTaylorMullen added a commit that referenced this issue May 22, 2015
@NTaylorMullen
Add IPlugin protocol to PluginHandler.
25feee3 
- When a plugin is registered with the system a client protocol can now be provided. This protocol is then cross checked with the created IPlugin's protocol and the result of Register returns the Protocol that will be used when communicating with the registered Plugin.
- Added tests to validate error conditions and protocol resolutions.

#1905
@NTaylorMullen
Copy link
Member Author

25feee3

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@NTaylorMullen NTaylorMullen

Labels
3 - Done enhancement
Projects
None yet
Milestone
1.0.0-beta5
Development

No branches or pull requests
2 participants
@danroth27 @NTaylorMullen