This repository has been archived by the owner on Feb 23, 2021. It is now read-only.
Downgrade user-secrets CLI tool to use 1.0.0 runtime #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natemcmaster
force-pushed
the
namc/tool-downgrade
branch
from
1a3069e
to
e5b7235
Compare
|
Ping. Can someone review this? |
| { | ||
| Logger.LogDebug(Resources.Message_Project_File_Path, projectPath); | ||
| var secretsFilePath = PathHelper.GetSecretsPath(projectPath); | ||
| Logger.LogDebug(Resources.Message_Secret_File_Path, secretsFilePath); | ||
|
|
||
| { | ||
| // workaround https://github.com/aspnet/Configuration/issues/478 |
There was a problem hiding this comment.
Could you file a bug for this and self assign? Easy to miss TODOs in code.
There was a problem hiding this comment.
Good idea. Added #102
|
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This required splitting runtime testing into its own project.
Will split a rel/tools-rel-1.0.0-preview3 branch after this merges. cref #100
cc @pranavkm @muratg