Skip to content
This repository has been archived by the owner on Feb 23, 2021. It is now read-only.

Consume first TFM when resolving TagHelperDescriptors. #49

Closed
NTaylorMullen opened this issue Mar 8, 2016 · 1 comment
Closed

Consume first TFM when resolving TagHelperDescriptors. #49

NTaylorMullen opened this issue Mar 8, 2016 · 1 comment
Assignees

Comments

@NTaylorMullen
Copy link
Member

Today we have the ability to specify a TFM when resolving TagHelperDescriptors. The problem with this approach is that the Razor editor does not have this capability. Instead it always picks the first TFM when showcasing C# intellisense.

A second part of what we currently do today is if a user has a project.json file with a TFM such as netstandardapp1.5 the TargetFramework identifier according to the dotnet project model loader is .NETStandardApp. This means we'd either need to query them for a set of names for the associated TFM or hardcode a set of name. Neither is great.

Lets do what the .cshtml editor does today for consistency and consume the first TFM present so you don't get any odd artifacts in your cshtml.

@NTaylorMullen NTaylorMullen self-assigned this Mar 8, 2016
@NTaylorMullen NTaylorMullen added this to the 1.0.0-rc2 milestone Mar 8, 2016
NTaylorMullen added a commit that referenced this issue Mar 9, 2016
- This makes RazorTooling consistent with the .cshtml editor.
- Added `project.json` tests to validate new behavior of throwing an appropriate error/selecting the first TFM.

#49
NTaylorMullen added a commit that referenced this issue Mar 9, 2016
- This makes RazorTooling consistent with the .cshtml editor.
- Added `project.json` tests to validate new behavior of throwing an appropriate error/selecting the first TFM.

#49
@NTaylorMullen
Copy link
Member Author

c39218f

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant