Skip to content
This repository has been archived by the owner on Dec 19, 2018. It is now read-only.

Multiple [TargetElement] attributes on a single TagHelper should de-dup if multiple match. #326

Closed
NTaylorMullen opened this issue Mar 20, 2015 · 1 comment
Closed

Multiple [TargetElement] attributes on a single TagHelper should de-dup if multiple match. #326

NTaylorMullen opened this issue Mar 20, 2015 · 1 comment
Assignees
@NTaylorMullen
Labels
3 - Done enhancement
Milestone
1.0.0-beta4

Comments

@NTaylorMullen
Copy link
Member

If I have:

[TargetElement(Attributes = "a")]
[TargetElement(Attributes = "b")]
public class FooTagHelper : TagHelper {}

And I write <foo a="" b="" /> the FooTagHelper class should not be run twice.
@NTaylorMullen NTaylorMullen self-assigned this Mar 20, 2015
@NTaylorMullen NTaylorMullen added this to the 4.0.0-beta4 milestone Mar 20, 2015
NTaylorMullen added a commit that referenced this issue Mar 20, 2015
@NTaylorMullen
De-dupe TagHelperDescriptors based on Type for rendering.
6596842 
- This can occur if you have multiple [TargetElement] attributes that overlap. Ultimately the descriptor is the same because its the same type, just the required attributes differ.
- Added a test to validate.

#326
NTaylorMullen added a commit that referenced this issue Mar 20, 2015
@NTaylorMullen
De-dupe TagHelperDescriptors based on Type for rendering.
b8432b7 
- This can occur if you have multiple [TargetElement] attributes that overlap. Ultimately the descriptor is the same because its the same type, just the required attributes differ.
- Added tests to validate.

#326
NTaylorMullen added a commit that referenced this issue Mar 20, 2015
@NTaylorMullen
De-dupe TagHelperDescriptors based on Type for rendering.
842549b 
- This can occur if you have multiple [TargetElement] attributes that overlap. Ultimately the descriptor is the same because its the same type, just the required attributes differ.
- Added tests to validate.

#326
@NTaylorMullen NTaylorMullen mentioned this issue Mar 20, 2015
Merged
@NTaylorMullen
Copy link
Member Author

842549b
2b62202

NTaylorMullen added a commit that referenced this issue Mar 20, 2015
@NTaylorMullen
Updated duplicate TargetElement TagHelper tests.
2b62202 
#326
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@NTaylorMullen NTaylorMullen

Labels
3 - Done enhancement
Projects
None yet
Milestone
1.0.0-beta4
Development

No branches or pull requests
1 participant
@NTaylorMullen