This repository has been archived by the owner on Dec 14, 2018. It is now read-only.
Correct HTML and JavaScript encoding of <link> and <script> attribute values
#4272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bute values - #4083 - `<link>` tag helper did not HTML encode `href` values in fallback elements - `<script>` tag helper did not correctly encode any attribute value in fallback elements - e.g. double quotes in literal strings would slip through - only needed to change one existing unit test (!!); so added a bunch nit: use `Process()`, not `ProcessAsync()` in `<script>` tag helper tests
| else | ||
| { | ||
| var writer = StringWriter; | ||
| RazorPage.WriteTo(writer, HtmlEncoder, value); |
There was a problem hiding this comment.
This static method isn't fitting so well in RazorPage but I haven't got a better place to throw it. Will leave as-is unless someone has a good suggestion.
|
|
, seems straighforward.
| // Value likely came from an HTML context in the .cshtml file but may still contain double quotes | ||
| // since attribute could have been enclosed in single quotes. | ||
| stringValue = htmlEncodedString.Value; | ||
| if (stringValue.Contains("\"")) |
There was a problem hiding this comment.
This check shouldn't be required. Calling stringValue.Replace would no-op if it doesn't have a quote.
There was a problem hiding this comment.
👌 double-checked the native source and confirmed that.
|
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
<link>and<script>tag helpers do not encode correctly #4083<link>tag helper did not HTML encodehrefvalues in fallback elements<script>tag helper did not correctly encode any attribute value in fallback elementsnit: use
Process(), notProcessAsync()in<script>tag helper tests