This repository has been archived by the owner on Dec 14, 2018. It is now read-only.
Get tets working with core.autocrlf=false
#2729
Closed
+484
−294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- #1514 - refactor `RazorCompilationService` to allow a test subclass that normalizes Razor file line endings - add `TestRazorCompilationService` to `RazorPageExecutionInstrumentationWebSite` - adjust line endings to match in `RazorPageExecutionInstrumentationTest` - add `ignoreLineEndingDifferences: true` to `Assert.Equal()` calls - responses on Windows can have a mix of line endings - `git config` setting affects line endings in .cshtml (and baseline) files - however MVC and Razor mix `Environment.NewLine`s into HTTP responses - update `PrecompilationTest` to split response regardless of line endings - update `ResourceFile` to normalize all source file streams to LF only - ensures consistent checksums and line mappings - change `MvcRazorHostTest` to expect new line mappings - recreate baseline files to expect new checksums and literal line endings - use verbatim strings in affected tests - careful use of `Environment.NewLine` in expectations is now just noise nits: - add doc comments in `RazorCompilationService` - correct `TagHelpersTest` name to match containing file - avoid incorrect `using` removal when `GENERATE_BASELINES` is not defined - remove unnecessary `ResourceFile` normalization of output files
|
/cc @somasegar because this PR likely interacts with your Travis work |
|
Sorry I meant to /cc @sornaks |
|
Looks |
to me!
|
Looks perfect! :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RazorCompilationServiceto allow a test subclass that normalizes Razor file line endingsTestRazorCompilationServicetoRazorPageExecutionInstrumentationWebSiteRazorPageExecutionInstrumentationTestignoreLineEndingDifferences: truetoAssert.Equal()callsgit configsetting affects line endings in .cshtml (and baseline) filesEnvironment.NewLines into HTTP responsesPrecompilationTestto split response regardless of line endingsResourceFileto normalize all source file streams to LF onlyMvcRazorHostTestto expect new line mappingsEnvironment.NewLinein expectations is now just noisenits:
RazorCompilationServiceTagHelpersTestname to match containing fileusingremoval whenGENERATE_BASELINESis not definedResourceFilenormalization of output files