This repository has been archived by the owner on Dec 14, 2018. It is now read-only.
Cleanup services #2034
Closed
Cleanup services #2034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
yishaigalatzer
commented
Feb 18, 2015
yishaigalatzer
commented
- Make explicit registration for nested provider manager (solves a problem with ninject for default MV MvcServices.GetDefaultServices breaks Ninject #953)
- Remove registation for async nested provider manager
- Make Action selector a singleton (should assist in perf), and cleanup related interface to allow that to happen
- Fix up the related tests
ghost
added
the
| @@ -860,7 +861,7 @@ private static RouteContext CreateRouteContext(string httpMethod) | |||
| var routeData = new RouteData(); | |||
| routeData.Routers.Add(new Mock<IRouter>(MockBehavior.Strict).Object); | |||
|
|
|||
| var httpContext = new Mock<HttpContext>(MockBehavior.Strict); | |||
| var httpContext = new Mock<HttpContext>(MockBehavior.Loose); | |||
There was a problem hiding this comment.
This makes me nervous. Can you just set the properties that are being used in the test (assuming it's the service provider).
There was a problem hiding this comment.
It makes a big messy to the tests, I'm not sure how important this is, lets talk in person.
There was a problem hiding this comment.
We are going to make it strict, and pass services, as well as remove setting services on HttpContext from the test above
|
|
after looking at changing mock back to strict
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.