Skip to content
This repository has been archived by the owner on Nov 29, 2018. It is now read-only.

ResourceStringLocalizerFactory creates string localizer based on resourcetype's name instead of full name #90

Closed
kirthik opened this issue Sep 25, 2015 · 4 comments
Closed

ResourceStringLocalizerFactory creates string localizer based on resourcetype's name instead of full name #90

kirthik opened this issue Sep 25, 2015 · 4 comments
Assignees
@kirthik
Labels
3 - Done bug
Milestone
1.0.0-rc1

Comments

@kirthik
Copy link
Contributor

kirthik commented Sep 25, 2015

https://github.com/aspnet/Localization/blob/dev/src/Microsoft.Extensions.Localization/ResourceManagerStringLocalizerFactory.cs#L53

We should use resourceName.FullName so that if same class exists under different namespaces, we can have different .resx for each type.
@kirthik kirthik mentioned this issue Sep 25, 2015
Closed
@Eilon
Copy link
Member

Eilon commented Sep 26, 2015

@DamianEdwards thoughts?

@DamianEdwards
Copy link
Member

It used to be FullName but was changed in eefe518. If we use FullName again, then the resource name would become ApplicationName + _resourcesBasePath + type.FullName, yes?

@kirthik
Copy link
Contributor Author

kirthik commented Oct 5, 2015

Yes. That is correct.

@Eilon Eilon added this to the 1.0.0-rc1 milestone Oct 5, 2015
@DamianEdwards
Copy link
Member

OK.

kirthik added a commit that referenced this issue Oct 16, 2015
@kirthik
fix #90: ResourceStringLocalizerFactory creates string localizer base…
9e03c49 
…d on resourcetype's name instead of full name
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@kirthik kirthik

Labels
3 - Done bug
Projects
None yet
Milestone
1.0.0-rc1
Development

No branches or pull requests
3 participants
@Eilon @DamianEdwards @kirthik