Skip to content
This repository has been archived by the owner on Dec 19, 2018. It is now read-only.

Add ASPNETCORE_* environment variables by default to hosting configuration #700

Closed
davidfowl opened this issue Apr 14, 2016 · 3 comments
Closed

Add ASPNETCORE_* environment variables by default to hosting configuration #700

davidfowl opened this issue Apr 14, 2016 · 3 comments
Assignees
@JunTaoLuo
Labels
3 - Done enhancement
Milestone
1.0.0-rc2

Comments

@davidfowl
Copy link
Member

Today you have to call UseDefaultConfiguration to turn on the ASPNETCORE_ environment variables. This means that ASPNETCORE_ settings aren't applied unless the application code is setup to do so. While this seems like a pure choice, it makes it hard to diagnose why things aren't working. An example of this is the IISIntegration middleware. If you don't call UseDefaultConfiguration then it won't bind to IIS.

Instead, we should just setup the the env vars by default.

/cc @DamianEdwards @Tratcher
davidfowl added a commit that referenced this issue Apr 14, 2016
@davidfowl
Always add ASP.NET Core env vars
0f872b8 
#700
@davidfowl davidfowl self-assigned this Apr 14, 2016
@davidfowl davidfowl mentioned this issue Apr 14, 2016
Closed
@Tratcher
Copy link
Member

How do you turn it off?

@LeandroPT
Copy link

Hello all...

This should be reflected in all examples with upper cases :), specially hosting in IIS...

I have been banging my head with this.. Thanks for the post 👍

@muratg muratg mentioned this issue Apr 26, 2016
Closed
@muratg muratg added this to the 1.0.0-rc2 milestone Apr 26, 2016
@muratg muratg assigned JunTaoLuo and unassigned davidfowl Apr 26, 2016
@muratg
Copy link

muratg commented Apr 26, 2016

@JunTaoLuo We think this is required for #727.

cc @Tratcher

@guardrex guardrex mentioned this issue Apr 26, 2016
Closed
32 tasks
JunTaoLuo added a commit that referenced this issue Apr 27, 2016
@JunTaoLuo
#700 #727 Add environment variables by default and remove UseDefaultH…
1f61593 
…ostingConfiguration
@JunTaoLuo JunTaoLuo mentioned this issue Apr 27, 2016
Merged
JunTaoLuo added a commit that referenced this issue Apr 27, 2016
@JunTaoLuo
#700 #727 Add environment variables by default and remove UseDefaultH…
109c28f 
…ostingConfiguration
JunTaoLuo added a commit that referenced this issue Apr 27, 2016
@JunTaoLuo
#700 #727 Add environment variables by default and remove UseDefaultH…
587c746 
…ostingConfiguration
JunTaoLuo added a commit that referenced this issue Apr 27, 2016
@JunTaoLuo
#700 #727 Add environment variables by default and remove UseDefaultH…
79a7143 
…ostingConfiguration
JunTaoLuo added a commit that referenced this issue Apr 27, 2016
@JunTaoLuo
#700 #727 Add environment variables by default and remove UseDefaultH…
e505ecb 
…ostingConfiguration
@BrennanConroy BrennanConroy mentioned this issue Apr 29, 2016
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@JunTaoLuo JunTaoLuo

Labels
3 - Done enhancement
Projects
None yet
Milestone
1.0.0-rc2
Development

No branches or pull requests
5 participants
@davidfowl @muratg @Tratcher @JunTaoLuo @LeandroPT