Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: drop support for current required behavior and just provide the conversion follow specs #179

Merged
merged 1 commit into from
Mar 4, 2022

Conversation

LumaKernel
Copy link
Contributor

@LumaKernel LumaKernel commented Mar 2, 2022

Types of changes

Changes

  • ...

Additional context

This is breaking change but not bump the major version.

Community note

Please upvode with reacting as 👍 to express your agreement.

@LumaKernel
Copy link
Contributor Author

note: freee publishes newer version of their schema: https://github.com/freee/freee-api-schema

Copy link
Member

@solufa solufa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

この破壊的な変更提案に対し、オリジナル開発者として同意しました
As the original developer, I agree with this proposed disruptive change.

@ghost
Copy link

ghost commented Mar 2, 2022

私が確認した限りだと怪しいところはないと思います。そのため、私もこの破壊的変更に同意します

@LumaKernel LumaKernel merged commit 8e23749 into aspida:main Mar 4, 2022
@LumaKernel LumaKernel deleted the main branch March 4, 2022 02:04
@LumaKernel LumaKernel added enhancement New feature or request feature and removed enhancement New feature or request labels Mar 4, 2022
@LumaKernel LumaKernel mentioned this pull request Mar 7, 2022
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants