fix(worker): workaround webpack4 fs write caching #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbedard
commented
Nov 8, 2023
|
|
||
| // Clear the full "emitting sources" cache in <v5 'futureEmitAssets' mode: |
There was a problem hiding this comment.
Turns out the previous webpack 4 solution wasn't enough.
As @thesayyn discovered webpack4 doesn't even reach the asset-emitting logic for some cases such as when only html files change (then it seems .js files won't even make it to the code the previous fix was for).
thesayyn
approved these changes
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #126
A webpack4 solution to #126 where webpack caches write operations.