Don't bake env into binary #464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This mirrors the behavior of rules_python's py_binary, and other *_binary rules. Previously any env set on the binary was baked into the script, and therefore included if the script was run with --run_under, or through a genrule. Now this env is passed through to RunEnvironmentInfo so it only applies in the default cases.
alexeagle
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This mirrors the behavior of rules_python's py_binary, and other
*_binary rules. Previously any env set on the binary was baked into the
script, and therefore included if the script was run with --run_under,
or through a genrule. Now this env is passed through to
RunEnvironmentInfo so it only applies in the default cases.